Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for the translation of the word 'next' in greek #759

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

orfeasa
Copy link
Contributor

@orfeasa orfeasa commented Jun 9, 2020

The word for "next", used when doing table pagination (next page), is επόμενη. However, there was a typo and the first letter of the Greek translation was the Latin alphabet equivalent e, instead of ε. This PR just replaces the letter and fixes the Greek translation.

@mgrdcm
Copy link

mgrdcm commented Jun 28, 2020

I don't speak Greek to be able to verify, but it looks like Google Translate can verify that this is correct: https://translate.google.com/#view=home&op=translate&sl=auto&tl=en&text=επόμενη

And Google Translate also suggests that the previous was wrong: https://translate.google.com/#view=home&op=translate&sl=auto&tl=en&text=eπόμενη
(note it says "Did you mean: επόμενη" that Google suggests on this link).

(Not doubting your PR just wondering if this is still open because no reviewers speak Greek :)

@spapas
Copy link
Contributor

spapas commented Aug 7, 2020

Hello @jieter sorry I haven't seen this PR ! Yes that's the correct translation please merge it.

Kind regards,
Serafeim

@spapas
Copy link
Contributor

spapas commented Aug 7, 2020

Also I don't think there's any problems with the translation of previous. Just to clarify more the correct translations are:

next = επόμενη
previous = προηγούμενη

I think that @mgrdcm wanted to suggest that the previous translation of next was wrong, not the translation of "previous" :)

@spapas
Copy link
Contributor

spapas commented Aug 7, 2020

Also, sorry for all those comments but I checked out my original commit for the greek translation: 6fbfdd4

If you see there the translations used a capital first letter so Next was Επόμενη. It seems that somehow the translations were changed to all small letters and the capital greek E was change to a lowercase english e instead of the lowercase greek ε!

@jieter
Copy link
Owner

jieter commented Aug 12, 2020

@spapas OK, thanks for reviewing. @orfeasa thanks for the patch!

@jieter jieter merged commit cf4312b into jieter:master Aug 12, 2020
@orfeasa
Copy link
Contributor Author

orfeasa commented Aug 12, 2020

Happy to contribute!

@spapas spapas mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants